Handle new Transformers v5 return type#3353
Draft
rootonchair wants to merge 1 commit intoLightning-AI:masterfrom
Draft
Handle new Transformers v5 return type#3353rootonchair wants to merge 1 commit intoLightning-AI:masterfrom
rootonchair wants to merge 1 commit intoLightning-AI:masterfrom
Conversation
Collaborator
|
Thanks @rootonchair for the PR. We will come back to it. Currently, we do not have the setup to test with the newest transformer version, but we will look into it soon. Thanks for your patience. In the meantime, if you could add more context to the PR description and link to some relevant references, that would be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Transformers new return
BaseModelOutputWithPoolingforget_text_features,get_image_featureswhich cause AttributeError when we call a function available on TensorBefore submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3353.org.readthedocs.build/en/3353/